Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iox-#1755 Port to new macro #2038

Merged
merged 2 commits into from
Oct 24, 2023
Merged

iox-#1755 Port to new macro #2038

merged 2 commits into from
Oct 24, 2023

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Sep 28, 2023 •
edited
Loading

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

This PR ports the code to the new log macro with lazy evaluation and removes the old macro.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added the refactoring Refactor code without adding features label Sep 28, 2023
@elBoberido elBoberido self-assigned this Sep 28, 2023
@elBoberido elBoberido changed the title iox-#1755 Port to new macro [Based on #2037] iox-#1755 Port to new macro Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Merging #2038 (0234a89) into master (4fb0b5f) will increase coverage by 0.19%.
Report is 9 commits behind head on master.
The diff coverage is 32.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2038      +/-   ##
==========================================
+ Coverage   74.23%   74.43%   +0.19%     
==========================================
  Files         417      417              
  Lines       16290    15986     -304     
  Branches     2277     2272       -5     
==========================================
- Hits        12093    11899     -194     
+ Misses       3458     3304     -154     
- Partials      739      783      +44
Flag Coverage Δ
unittests 74.22% <32.06%> (+0.19%) ⬆️
unittests_timing 15.31% <0.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ceoryx_binding_c/source/c2cpp_enum_translation.cpp 100.00% <100.00%> (ø)
iceoryx_binding_c/source/c_publisher.cpp 92.50% <100.00%> (ø)
iceoryx_binding_c/source/c_subscriber.cpp 91.56% <100.00%> (ø)
iceoryx_binding_c/source/c_user_trigger.cpp 94.44% <100.00%> (ø)
...eoryx_hoofs/design/source/functional_interface.cpp 100.00% <100.00%> (ø)
...include/iceoryx_hoofs/posix_wrapper/posix_call.hpp 100.00% <ø> (ø)
iceoryx_hoofs/memory/source/bump_allocator.cpp 100.00% <100.00%> (ø)
iceoryx_hoofs/primitives/include/iox/size.hpp 50.00% <ø> (ø)
...ofs/reporting/include/iox/detail/log/logstream.inl 95.68% <ø> (-0.11%) ⬇️
iceoryx_hoofs/reporting/include/iox/logging.hpp 50.00% <ø> (ø)
... and 82 more

... and 1 file with indirect coverage changes

@elBoberido elBoberido force-pushed the iox-1755-port-to-new-macro branch 9 times, most recently from fa5f5db to 130d0a6 Compare September 30, 2023 13:24
@elBoberido elBoberido changed the title [Based on #2037] iox-#1755 Port to new macro iox-#1755 Port to new macro Oct 24, 2023
@elBoberido
Copy link
Member Author

@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff @budrus feel free to add yourself as reviewer

@elBoberido elBoberido merged commit 248f9d3 into eclipse-iceoryx:master Oct 24, 2023
15 of 16 checks passed
@elBoberido elBoberido deleted the iox-1755-port-to-new-macro branch October 24, 2023 14:08
@elBoberido elBoberido linked an issue Oct 24, 2023 that may be closed by this pull request
Enhance Logger #1755
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler FerdinandSpitzschnueffler approved these changes

@elfenpiff elfenpiff elfenpiff approved these changes

Assignees

@elBoberido elBoberido

Labels
refactoring Refactor code without adding features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Logger
3 participants
@elBoberido @elfenpiff @FerdinandSpitzschnueffler